webapps: initial addition of splash screen icon downloading

chrome/browser/android/banners/app_banner_manager_android.cc

Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 953c0e934e4eca9adaf4821cb644dc182130c3fd..419fb95987fcf85724532d9c9f439a6ab6f63cbc 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -30,10 +30,13 @@ const char kIdName[] = "id";
 
 namespace banners {
 
-AppBannerManagerAndroid::AppBannerManagerAndroid(JNIEnv* env,
-                                                 jobject obj,
-                                                 int icon_size)
-    : AppBannerManager(icon_size),
+AppBannerManagerAndroid::AppBannerManagerAndroid(
+  JNIEnv* env,

[gone, 2015/08/26 21:39:25]

Indentation is wrong.  You indent by 4 in C++ for long lines.

[Lalit Maganti, 2015/08/26 22:55:00]

Done.

+  jobject obj,
+  int ideal_splash_image_size_in_dp,
+  int ideal_icon_size_in_dp)
+    : AppBannerManager(ideal_icon_size_in_dp),
+      ideal_splash_image_size_in_dp_(ideal_splash_image_size_in_dp),
       weak_java_banner_view_manager_(env, obj) {
 }
 
@@ -83,7 +86,7 @@ bool AppBannerManagerAndroid::HandleNonWebApp(const std::string& platform,
       ConvertUTF8ToJavaString(env, referrer));
   Java_AppBannerManager_fetchAppDetails(env, jobj.obj(), jurl.obj(),
                                         jpackage.obj(), jreferrer.obj(),
-                                        ideal_icon_size());
+                                        ideal_icon_size_in_dp());
   return true;
 }
 
@@ -132,9 +135,10 @@ std::string AppBannerManagerAndroid::ExtractQueryValueForName(
 
 AppBannerDataFetcher* AppBannerManagerAndroid::CreateAppBannerDataFetcher(
     base::WeakPtr<Delegate> weak_delegate,
-    const int ideal_icon_size) {
+    const int ideal_icon_size_in_dp) {
   return new AppBannerDataFetcherAndroid(web_contents(), weak_delegate,
-                                         ideal_icon_size);
+                                         ideal_splash_image_size_in_dp_,
+                                         ideal_icon_size_in_dp);
 }
 
 bool AppBannerManagerAndroid::OnAppDetailsRetrieved(JNIEnv* env,
@@ -167,9 +171,13 @@ bool AppBannerManagerAndroid::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
-jlong Init(JNIEnv* env, jobject obj, jint icon_size) {
+jlong Init(JNIEnv* env,
+           jobject obj,
+           jint ideal_splash_image_size_in_dp,
+           jint ideal_icon_size_in_dp) {
   AppBannerManagerAndroid* manager =
-      new AppBannerManagerAndroid(env, obj, icon_size);
+      new AppBannerManagerAndroid(env, obj,
+          ideal_splash_image_size_in_dp, ideal_icon_size_in_dp);
   return reinterpret_cast<intptr_t>(manager);
 }