webapps: initial addition of splash screen icon downloading

chrome/browser/android/shortcut_helper.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_
 #define CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_weak_ref.h"
 #include "chrome/browser/android/shortcut_info.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 // ShortcutHelper is the C++ counterpart of org.chromium.chrome.browser's
-// ShortcutHelper in Java. The object is owned by the Java object. It is created
-// from there via a JNI (Initialize) call and MUST BE DESTROYED via Destroy().
+// ShortcutHelper in Java.
 class ShortcutHelper {

[mlamouri (slow - plz ping), 2015/08/24 16:43:54]

Maybe make it final?

[Lalit Maganti, 2015/08/25 11:38:44]

Done.

  public:
   // Registers JNI hooks.
   static bool RegisterShortcutHelper(JNIEnv* env);
 
   // Adds a shortcut to the launcher using a SkBitmap.
   // Must be called on the IO thread.
   static void AddShortcutInBackgroundWithSkBitmap(const ShortcutInfo& info,
+                                                  const std::string& id,

[mlamouri (slow - plz ping), 2015/08/24 16:43:54]

nit: id -> webapp_id

[Lalit Maganti, 2015/08/25 11:38:44]

Done.

                                                   const SkBitmap& icon_bitmap);
+
+  // Add splashscreen icon to the data of the webapp.
+  static void AddSplashscreenIconToWebappData(const std::string& id,

[mlamouri (slow - plz ping), 2015/08/24 16:43:54]

ditto

[Lalit Maganti, 2015/08/25 11:38:44]

Done.

+                                              const SkBitmap& splash_icon);
+
  private:
-  ShortcutHelper();
+  ShortcutHelper() = delete;
+  ~ShortcutHelper() = delete;
 
   DISALLOW_COPY_AND_ASSIGN(ShortcutHelper);
 };
 
 #endif  // CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_