chrome/browser/ui/cocoa/extensions/browser_action_button.mm - Issue 1310183005: Mac: Fix missing focus rings on toolbar, profile, and tab buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_action_button.mm

Issue 1310183005: Mac: Fix missing focus rings on toolbar, profile, and tab buttons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@snapshot

Patch Set: Fix extension buttons Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/down_arrow_popup_menu_cell.mm ('k') | chrome/browser/ui/cocoa/gradient_button_cell.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/browser_action_button.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_action_button.mm b/chrome/browser/ui/cocoa/extensions/browser_action_button.mm

index dfaf575ea5a4946e33f69f0e00d6bd4c113460ef..893584615417c1adc618b4100274167d0d3dc2a5 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_action_button.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_action_button.mm

@@ -549,6 +549,13 @@ void ToolbarActionViewDelegateBridge::DoShowContextMenu() {

hints:nil];

}

+- (void)drawFocusRingMaskWithFrame:(NSRect)cellFrame inView:(NSView*)view {

+ // Match the hover image's bezel.

+ [[NSBezierPath bezierPathWithRoundedRect:NSInsetRect(cellFrame, 2, 2)

+ xRadius:2

+ yRadius:2] fill];

- (ui::ThemeProvider*)themeProviderForWindow:(NSWindow*)window {

ui::ThemeProvider* themeProvider = [window themeProvider];

if (!themeProvider)

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/down_arrow_popup_menu_cell.mm ('k') | chrome/browser/ui/cocoa/gradient_button_cell.mm » ('j') | no next file with comments »