Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1310183005: Mac: Fix missing focus rings on toolbar, profile, and tab buttons (Closed)

Created:
5 years, 3 months ago by Andre
Modified:
5 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@snapshot
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix missing focus rings on toolbar, profile, and tab buttons This is a reland of http://crrev.com/1160143010, with some additional tweaks. It was reverted because it tickled an AppKit crash (crbug.com/504808). The hope is that the crash won't reappear now that we link with 10.10 SDK. In 10.7, AppKit introduced new API for drawing focus rings. This automatic focus ring drawing is automatically enabled for applications linking with 10.8 sdk or later. After we link with 10.10 SDK the new style focus ring gets enabled but we get focus rings with double lines. This is because AppKit thinks the buttons are bordered (-isBordered is YES) and draws lines inside and outside the borders that are actually not there due to drawing overrides. 10.6 before: manually drawn, tab close and avatar buttons missing focus rings. 10.6 after: no change. 10.7 before: broken, no focus rings on toolbar, avatar, tab close, new tab buttons. 10.7 after: manually drawn, same as 10.6. 10.8+ before: broken, no focus rings on toolbar, avatar, tab close, new tab buttons. 10.8+ after: drawn by AppKit. Toolbar.xib changes: Change the toolbar buttons (back, forward, reload, home, wrench) Focus Ring from None to Default, to allow the new style focus ring to draw. BUG=459860, 520471 Committed: https://crrev.com/9c75e3773754cfb242c2819cbfb45bd8b5ddf95f Cr-Commit-Position: refs/heads/master@{#345989}

Patch Set 1 #

Patch Set 2 : Fix Toolbar.xib #

Patch Set 3 : Fix extension buttons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -33 lines) Patch
M chrome/app/nibs/Toolbar.xib View 1 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/down_arrow_popup_menu_cell.mm View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.mm View 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/hover_close_button.mm View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/image_button_cell.mm View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/new_tab_button.mm View 3 chunks +15 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Andre
Robert PTAL.
5 years, 3 months ago (2015-08-27 17:20:08 UTC) #2
Robert Sesek
LGTM
5 years, 3 months ago (2015-08-27 20:04:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310183005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310183005/40001
5 years, 3 months ago (2015-08-27 20:33:45 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-27 21:11:21 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 21:12:00 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9c75e3773754cfb242c2819cbfb45bd8b5ddf95f
Cr-Commit-Position: refs/heads/master@{#345989}

Powered by Google App Engine
This is Rietveld 408576698