Chromium Code Reviews| Index: chrome/test/chromedriver/chrome/dom_tracker_unittest.cc |
| diff --git a/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc b/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc |
| index 4ba6dea9063ff6ace7980b1e68e3238c28c69f8e..ca63a55ece6d944602383f39b01a1cbb259ab6cb 100644 |
| --- a/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc |
| +++ b/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc |
| @@ -60,7 +60,7 @@ TEST(DomTracker, GetFrameIdForNode) { |
| " {\"nodeId\":102,\"frameId\":\"f\"}]" |
| "}]"; |
| base::DictionaryValue params; |
| - params.Set("nodes", base::JSONReader::DeprecatedRead(nodes)); |
| + params.Set("nodes", base::JSONReader::Read(nodes).release()); |
|
sky
2015/09/09 16:03:03
I think you should make DictionaryValue::Set take
|
| ASSERT_EQ(kOk, tracker.OnEvent(&client, "DOM.setChildNodes", params).code()); |
| ASSERT_TRUE(tracker.GetFrameIdForNode(101, &frame_id).IsError()); |
| ASSERT_TRUE(frame_id.empty()); |
| @@ -79,15 +79,15 @@ TEST(DomTracker, ChildNodeInserted) { |
| std::string frame_id; |
| base::DictionaryValue params; |
| - params.Set("node", base::JSONReader::DeprecatedRead("{\"nodeId\":1}")); |
| + params.Set("node", base::JSONReader::Read("{\"nodeId\":1}").release()); |
| ASSERT_EQ(kOk, |
| tracker.OnEvent(&client, "DOM.childNodeInserted", params).code()); |
| ASSERT_TRUE(tracker.GetFrameIdForNode(1, &frame_id).IsError()); |
| ASSERT_TRUE(frame_id.empty()); |
| params.Clear(); |
| - params.Set("node", base::JSONReader::DeprecatedRead( |
| - "{\"nodeId\":2,\"frameId\":\"f\"}")); |
| + params.Set("node", base::JSONReader::Read("{\"nodeId\":2,\"frameId\":\"f\"}") |
| + .release()); |
| ASSERT_EQ(kOk, |
| tracker.OnEvent(&client, "DOM.childNodeInserted", params).code()); |
| ASSERT_TRUE(tracker.GetFrameIdForNode(2, &frame_id).IsOk()); |