Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 1310153002: Switch from Google charts to Charted (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/debugger.dart
diff --git a/runtime/observatory/lib/src/elements/debugger.dart b/runtime/observatory/lib/src/elements/debugger.dart
index 9b3bced72e51a0178c6b80ecffa784f9ee00a74c..863928bdf63d872efeca9fe029b99101bfb75a15 100644
--- a/runtime/observatory/lib/src/elements/debugger.dart
+++ b/runtime/observatory/lib/src/elements/debugger.dart
@@ -1658,30 +1658,30 @@ class ObservatoryDebugger extends Debugger {
var event = isolate.pauseEvent;
if (event.kind == ServiceEvent.kPauseStart) {
console.print("Type 'continue' [F7] or 'step' [F10] to start the isolate");
- return;
+ return null;
}
if (event.kind == ServiceEvent.kPauseExit) {
console.print("Type 'continue' [F7] to exit the isolate");
- return;
+ return null;
}
return isolate.stepOver();
} else {
console.print('The program is already running');
- return;
+ return null;
}
}
- Future step() {
+ Future step() async {
if (isolatePaused()) {
var event = isolate.pauseEvent;
if (event.kind == ServiceEvent.kPauseExit) {
console.print("Type 'continue' [F7] to exit the isolate");
- return new Future.value(null);
+ return null;
}
return isolate.stepInto();
} else {
console.print('The program is already running');
- return new Future.value(null);
+ return null;
}
}
}
@@ -1784,7 +1784,7 @@ class DebuggerPageElement extends ObservatoryElement {
void detached() {
debugger.isolate = null;
_resizeSubscription.cancel();
- _resizeSubscrption = null;
+ _resizeSubscription = null;
cancelFutureSubscription(_isolateSubscriptionFuture);
_isolateSubscriptionFuture = null;
cancelFutureSubscription(_debugSubscriptionFuture);

Powered by Google App Engine
This is Rietveld 408576698