Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310133002: Add more components tests to GN build. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, jam, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more components tests to GN build. visitedlink, query_parser, web_cache, autofill CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_dbg TBR=-dpranke@chromium.org Reland of http://crrev.com/1303013005#ps40001 Committed: https://crrev.com/b4bb70f08420dadfd13e42658ae3caf180633778 Cr-Commit-Position: refs/heads/master@{#345010}

Patch Set 1 : Original patch #

Patch Set 2 : Warning fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -39 lines) Patch
M components/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/query_parser/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M components/visitedlink/browser/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M components/visitedlink/common/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M components/visitedlink/renderer/BUILD.gn View 1 chunk +13 lines, -14 lines 0 comments Download
A + components/visitedlink/test/BUILD.gn View 1 1 chunk +6 lines, -15 lines 0 comments Download
M components/web_cache/browser/BUILD.gn View 2 chunks +14 lines, -2 lines 0 comments Download
M components/web_cache/common/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M components/web_cache/renderer/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 4 months ago (2015-08-23 17:38:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310133002/20001
5 years, 4 months ago (2015-08-23 17:38:44 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (JOB_FAILED, no build URL)
5 years, 4 months ago (2015-08-23 17:39:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310133002/20001
5 years, 4 months ago (2015-08-23 17:49:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-23 18:31:51 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b4bb70f08420dadfd13e42658ae3caf180633778 Cr-Commit-Position: refs/heads/master@{#345010}
5 years, 4 months ago (2015-08-23 18:32:36 UTC) #10
Dirk Pranke
5 years, 4 months ago (2015-08-25 19:37:25 UTC) #11
Message was sent while issue was closed. 
rs lgtm

Powered by Google App Engine
This is Rietveld 408576698