Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 1310093007: Add a check for null returns from SpellChekerSessonBridge#create(). (Closed)

Created:
5 years, 3 months ago by aurimas (slooooooooow)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spellwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a check for null returns from SpellChekerSessonBridge#create(). When a spell checker service is not available on a device (e.g. Samsung S4) Android will return a null object and thus SpellCheckerSessionBride will return null. This CL adds early returns for such cases. BUG=529355 Committed: https://crrev.com/d6eca98dc5096dc8d739f7d3dd5188c99f1def2a Cr-Commit-Position: refs/heads/master@{#347849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/spellchecker/spellchecker_session_bridge_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/spellchecker/spellchecker_session_bridge_android.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
PTAL
5 years, 3 months ago (2015-09-08 23:38:14 UTC) #2
please use gerrit instead
lgtm
5 years, 3 months ago (2015-09-09 00:10:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310093007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310093007/1
5 years, 3 months ago (2015-09-09 00:11:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 00:42:41 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 00:43:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6eca98dc5096dc8d739f7d3dd5188c99f1def2a
Cr-Commit-Position: refs/heads/master@{#347849}

Powered by Google App Engine
This is Rietveld 408576698