Avoid dialogs and generating call stacks under a debugger

Avoid dialogs and generating call stacks under a debugger

If a process is being debugged when it hits a LOG_FATAL message then do
as little as possible before breaking in to the debugger.

R=thestig@chromium.org
BUG=528457
Committed: https://crrev.com/7c559eb3df01e99d457390cbd0bcfa38b6e05589
Cr-Commit-Position: refs/heads/master@{#347545}

[brucedawson, 2015-09-04 22:04:57]

What do you think about this change? It avoids some annoying problems on
Windows. See linked bug for details.

The benefit is much smaller on other platforms so I could make
base::debug::StackTrace change Windows specific if it's useful to the workflow
on other platforms.

[Lei Zhang, 2015-09-04 22:11:32]

lgtm

This does seem unnecessary when one already has the debugger open.

https://codereview.chromium.org/1310083004/diff/20001/base/logging.cc
File base/logging.cc (right):

https://codereview.chromium.org/1310083004/diff/20001/base/logging.cc#newcode548
base/logging.cc:548: if (!base::debug::BeingDebugged()) {
nit: combine with the if on the line above?

[brucedawson, 2015-09-04 23:05:28]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2015-09-04 23:05:28]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1310083004/#ps40001
(title: "Merging adjacent 'if' statements.")

[commit-bot: I haz the power, 2015-09-04 23:06:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310083004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310083004/40001

[commit-bot: I haz the power, 2015-09-05 00:34:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-05 00:35:36]

Patchset 3 (id:??) landed as
https://crrev.com/7c559eb3df01e99d457390cbd0bcfa38b6e05589
Cr-Commit-Position: refs/heads/master@{#347545}