Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310073007: Devtools UI: Add toggle record shortcut in network panel (Closed)

Created:
5 years, 3 months ago by samli
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools UI: Add toggle record shortcut in network panel For consistency with the timeline and profiles panel, network should have the same shortcut for toggling recording. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201496

Patch Set 1 #

Patch Set 2 : Update Mac shortcut #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M Source/devtools/front_end/network/NetworkPanel.js View 4 chunks +29 lines, -7 lines 0 comments Download
M Source/devtools/front_end/network/module.json View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
samli
5 years, 3 months ago (2015-08-28 22:47:19 UTC) #2
pfeldman
lgtm
5 years, 3 months ago (2015-08-28 23:05:26 UTC) #3
pfeldman
We should also make them work from the inspected page.
5 years, 3 months ago (2015-08-28 23:05:41 UTC) #4
samli
On 2015/08/28 at 23:05:41, pfeldman wrote: > We should also make them work from the ...
5 years, 3 months ago (2015-08-28 23:40:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310073007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310073007/1
5 years, 3 months ago (2015-08-28 23:40:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/46510)
5 years, 3 months ago (2015-08-29 01:36:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310073007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310073007/1
5 years, 3 months ago (2015-08-31 15:48:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/62761)
5 years, 3 months ago (2015-08-31 16:51:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310073007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310073007/20001
5 years, 3 months ago (2015-08-31 18:16:58 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 19:32:11 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201496

Powered by Google App Engine
This is Rietveld 408576698