Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310073003: Fix _first_enum_value usage on make_css_property_names.py (Closed)

Created:
5 years, 4 months ago by Timothy Loh
Modified:
5 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix _first_enum_value usage on make_css_property_names.py This patch fixes make_css_property_names.py to use _first_enum_value where appropriate so that the value can be updated in the future. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/build/scripts/css_properties.py View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/build/scripts/make_css_property_names.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Timothy Loh
5 years, 4 months ago (2015-08-25 09:18:26 UTC) #2
alancutter (OOO until 2018)
lgtm
5 years, 4 months ago (2015-08-25 09:32:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310073003/1
5 years, 4 months ago (2015-08-25 09:33:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103742)
5 years, 4 months ago (2015-08-25 10:34:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310073003/1
5 years, 4 months ago (2015-08-25 10:38:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103793)
5 years, 4 months ago (2015-08-25 11:30:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310073003/1
5 years, 4 months ago (2015-08-25 22:50:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104267)
5 years, 4 months ago (2015-08-26 00:12:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310073003/1
5 years, 4 months ago (2015-08-26 01:16:39 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 02:02:43 UTC) #18
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201183

Powered by Google App Engine
This is Rietveld 408576698