Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 1310063002: Snapshot a pointer to the main frame when creating WebViewFrameWidget. (Closed)

Created:
5 years, 4 months ago by dcheng
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Snapshot a pointer to the main frame when creating WebViewFrameWidget. Otherwise, invoking WebViewFrameWidget::close() from frame swap will result in trying to clear the frame widget on the wrong main frame. Other miscellaneous fixes: - WebViewFrameWidget now uses smart pointers where appropriate for its members. - WebViewFrameWidget's ctor also takes a WebWidgetClient* pointer. This is future-proofing to help merge the widget implementations in WebFrameWidget and WebView. BUG=419087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201048

Patch Set 1 #

Patch Set 2 : Futureproof #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M Source/web/WebFrameWidgetImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebViewFrameWidget.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M Source/web/WebViewFrameWidget.cpp View 1 2 chunks +10 lines, -3 lines 0 comments Download
M public/web/WebFrameWidget.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dcheng
This is needed to unblock progress on https://codereview.chromium.org/1303773002 as well.
5 years, 4 months ago (2015-08-24 00:12:34 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-24 01:00:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310063002/20001
5 years, 4 months ago (2015-08-24 02:23:31 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 04:16:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201048

Powered by Google App Engine
This is Rietveld 408576698