Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310053007: Remove a duplicate test (Closed)

Created:
5 years, 3 months ago by Stephen Chennney
Modified:
5 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove a duplicate test fast/repaint/box-shadow-h and fast/repaint/box-shadow-v are identical, so one of them should be removed. And the -h and -v don't mean anything, so rename the remaining test. And the test is not a repaint test, so move it to the right location. R=pdr@chromium.org BUG=344745 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-5 lines, -1429 lines) Patch
A + LayoutTests/fast/box-shadow/box-shadow.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/fast/repaint/box-shadow-h.html View 1 chunk +0 lines, -141 lines 0 comments Download
D LayoutTests/fast/repaint/box-shadow-v.html View 1 chunk +0 lines, -141 lines 0 comments Download
A + LayoutTests/platform/linux/fast/box-shadow/box-shadow-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/linux/fast/box-shadow/box-shadow-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/linux/fast/repaint/box-shadow-h-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/repaint/box-shadow-h-expected.txt View 1 chunk +0 lines, -144 lines 0 comments Download
D LayoutTests/platform/linux/fast/repaint/box-shadow-v-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/repaint/box-shadow-v-expected.txt View 1 chunk +0 lines, -144 lines 0 comments Download
A + LayoutTests/platform/mac/fast/box-shadow/box-shadow-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac/fast/box-shadow/box-shadow-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/mac/fast/repaint/box-shadow-h-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/repaint/box-shadow-h-expected.txt View 1 chunk +0 lines, -144 lines 0 comments Download
D LayoutTests/platform/mac/fast/repaint/box-shadow-v-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/repaint/box-shadow-v-expected.txt View 1 chunk +0 lines, -144 lines 0 comments Download
A + LayoutTests/platform/win-xp/fast/box-shadow/box-shadow-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/win-xp/fast/box-shadow/box-shadow-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/repaint/box-shadow-h-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/repaint/box-shadow-h-expected.txt View 1 chunk +0 lines, -144 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/repaint/box-shadow-v-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/repaint/box-shadow-v-expected.txt View 1 chunk +0 lines, -144 lines 0 comments Download
A + LayoutTests/platform/win/fast/box-shadow/box-shadow-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/win/fast/box-shadow/box-shadow-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win/fast/repaint/box-shadow-h-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/box-shadow-h-expected.txt View 1 chunk +0 lines, -144 lines 0 comments Download
D LayoutTests/platform/win/fast/repaint/box-shadow-v-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/box-shadow-v-expected.txt View 1 chunk +0 lines, -144 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Stephen Chennney
Straight up renaming and removal of duplicate test.
5 years, 3 months ago (2015-08-28 15:20:15 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310053007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310053007/1
5 years, 3 months ago (2015-08-28 15:20:35 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 16:14:07 UTC) #5
pdr.
LGTM
5 years, 3 months ago (2015-08-28 17:49:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310053007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310053007/1
5 years, 3 months ago (2015-08-28 17:49:42 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 17:54:49 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201415

Powered by Google App Engine
This is Rietveld 408576698