Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1310053005: Make implicit casts hints (Closed)

Created:
5 years, 3 months ago by vsm
Modified:
5 years, 3 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org, Brian Wilkerson
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make implicit casts hints This appears to cut out about 1/3 of the strong mode errors reported in angular2. The actual cases removed that I looked at seem fine - e.g., we may inject an implicit cast, but it'll work fine at runtime. Fixes #302 R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/a7533099d6fd5b0a216aa4c001e4199dcfe92a6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -124 lines) Patch
M lib/src/info.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/checker/checker_test.dart View 22 chunks +51 lines, -51 lines 0 comments Download
M test/codegen/expect/methods.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M tool/sdk_expected_errors.txt View 12 chunks +4 lines, -70 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vsm
5 years, 3 months ago (2015-08-26 21:21:41 UTC) #2
Leaf
lgtm
5 years, 3 months ago (2015-08-26 21:25:22 UTC) #3
yjbanov
On 2015/08/26 21:21:41, vsm wrote: What would be DDC's output when it encounters an implicit ...
5 years, 3 months ago (2015-08-26 21:26:23 UTC) #4
vsm
On 2015/08/26 21:26:23, yjbanov wrote: > On 2015/08/26 21:21:41, vsm wrote: > > What would ...
5 years, 3 months ago (2015-08-26 21:36:07 UTC) #5
vsm
5 years, 3 months ago (2015-08-26 22:02:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7533099d6fd5b0a216aa4c001e4199dcfe92a6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698