Issue 1310053004: Fix clipped lighting image filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1310053004: Fix clipped lighting image filters. (Closed)

Created:
5 years, 3 months ago by Stephen White

Modified:
5 years, 3 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix clipped lighting image filters. The CPU path for lighting image filters was not adjusting the filter matrix to accommodate srcOffset, resulting in incorrectly-positioned lights. (The GPU path was doing this correctly.) This change adds a new test case to the imagefiltersclipped GM, so it will need new baselines. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7b7ecfc046f7ec810482266db3430d1358b7a5bf

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	gm/imagefiltersclipped.cpp	View		3 chunks	+5 lines, -0 lines	0 comments	Download
	M	src/effects/SkLightingImageFilter.cpp	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310053004/1

5 years, 3 months ago (2015-08-26 21:20:16 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-08-26 21:26:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7b7ecfc046f7ec810482266db3430d1358b7a5bf

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages