Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 1310043003: Introduce previousPositionOf() for VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-28T16:28:03 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/editing/VisiblePosition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index a9ca281adba5bccd01a0725c682adbe0899600a0..bb9575eb0abe5b78a12fb279faa7edd5be5edba4 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -668,7 +668,7 @@ VisiblePosition FrameSelection::modifyExtendingRight(TextGranularity granularity
if (directionOfEnclosingBlock() == LTR)
pos = pos.next(CanSkipOverEditingBoundary);
else
- pos = pos.previous(CanSkipOverEditingBoundary);
+ pos = previousPositionOf(pos, CanSkipOverEditingBoundary);
break;
case WordGranularity:
if (directionOfEnclosingBlock() == LTR)
@@ -831,7 +831,7 @@ VisiblePosition FrameSelection::modifyExtendingLeft(TextGranularity granularity)
switch (granularity) {
case CharacterGranularity:
if (directionOfEnclosingBlock() == LTR)
- pos = pos.previous(CanSkipOverEditingBoundary);
+ pos = previousPositionOf(pos, CanSkipOverEditingBoundary);
else
pos = pos.next(CanSkipOverEditingBoundary);
break;
@@ -870,7 +870,7 @@ VisiblePosition FrameSelection::modifyExtendingBackward(TextGranularity granular
// over everything.
switch (granularity) {
case CharacterGranularity:
- pos = pos.previous(CanSkipOverEditingBoundary);
+ pos = previousPositionOf(pos, CanSkipOverEditingBoundary);
break;
case WordGranularity:
pos = previousWordPosition(pos);
@@ -948,7 +948,7 @@ VisiblePosition FrameSelection::modifyMovingBackward(TextGranularity granularity
if (isRange())
pos = VisiblePosition(m_selection.start(), m_selection.affinity());
else
- pos = VisiblePosition(m_selection.extent(), m_selection.affinity()).previous(CanSkipOverEditingBoundary);
+ pos = previousPositionOf(VisiblePosition(m_selection.extent(), m_selection.affinity()), CanSkipOverEditingBoundary);
break;
case WordGranularity:
pos = previousWordPosition(VisiblePosition(m_selection.extent(), m_selection.affinity()));
« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/editing/VisiblePosition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698