Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: chrome/browser/autocomplete/zero_suggest_provider.h

Issue 131003011: Part 1 of search provider refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file contains the zero-suggest autocomplete provider. This experimental 5 // This file contains the zero-suggest autocomplete provider. This experimental
6 // provider is invoked when the user focuses in the omnibox prior to editing, 6 // provider is invoked when the user focuses in the omnibox prior to editing,
7 // and generates search query suggestions based on the current URL. To enable 7 // and generates search query suggestions based on the current URL. To enable
8 // this provider, point --experimental-zero-suggest-url-prefix at an 8 // this provider, point --experimental-zero-suggest-url-prefix at an
9 // appropriate suggestion service. 9 // appropriate suggestion service.
10 // 10 //
11 // HUGE DISCLAIMER: This is just here for experimenting and will probably be 11 // HUGE DISCLAIMER: This is just here for experimenting and will probably be
12 // deleted entirely as we revise how suggestions work with the omnibox. 12 // deleted entirely as we revise how suggestions work with the omnibox.
13 13
14 #ifndef CHROME_BROWSER_AUTOCOMPLETE_ZERO_SUGGEST_PROVIDER_H_ 14 #ifndef CHROME_BROWSER_AUTOCOMPLETE_ZERO_SUGGEST_PROVIDER_H_
15 #define CHROME_BROWSER_AUTOCOMPLETE_ZERO_SUGGEST_PROVIDER_H_ 15 #define CHROME_BROWSER_AUTOCOMPLETE_ZERO_SUGGEST_PROVIDER_H_
16 16
17 #include <map> 17 #include <map>
18 #include <string> 18 #include <string>
19 #include <vector> 19 #include <vector>
20 20
21 #include "base/basictypes.h" 21 #include "base/basictypes.h"
22 #include "base/compiler_specific.h" 22 #include "base/compiler_specific.h"
23 #include "base/memory/scoped_ptr.h" 23 #include "base/memory/scoped_ptr.h"
24 #include "base/strings/string16.h" 24 #include "chrome/browser/autocomplete/base_search_provider.h"
25 #include "chrome/browser/autocomplete/autocomplete_provider.h"
26 #include "chrome/browser/autocomplete/search_provider.h" 25 #include "chrome/browser/autocomplete/search_provider.h"
27 #include "net/url_request/url_fetcher_delegate.h"
28 26
29 class AutocompleteInput;
30 class GURL;
31 class TemplateURLService; 27 class TemplateURLService;
32 28
33 namespace base { 29 namespace base {
34 class ListValue; 30 class ListValue;
35 class Value; 31 class Value;
36 } 32 }
37 33
38 namespace net { 34 namespace net {
39 class URLFetcher; 35 class URLFetcher;
40 } 36 }
41 37
42 // Autocomplete provider for searches based on the current URL. 38 // Autocomplete provider for searches based on the current URL.
43 // 39 //
44 // The controller will call StartZeroSuggest when the user focuses in the 40 // The controller will call StartZeroSuggest when the user focuses in the
45 // omnibox. After construction, the autocomplete controller repeatedly calls 41 // omnibox. After construction, the autocomplete controller repeatedly calls
46 // Start() with some user input, each time expecting to receive an updated 42 // Start() with some user input, each time expecting to receive an updated
47 // set of matches. 43 // set of matches.
48 // 44 //
49 // TODO(jered): Consider deleting this class and building this functionality 45 // TODO(jered): Consider deleting this class and building this functionality
50 // into SearchProvider after dogfood and after we break the association between 46 // into SearchProvider after dogfood and after we break the association between
51 // omnibox text and suggestions. 47 // omnibox text and suggestions.
52 class ZeroSuggestProvider : public AutocompleteProvider, 48 class ZeroSuggestProvider : public BaseSearchProvider {
53 public net::URLFetcherDelegate {
54 public: 49 public:
55 // Creates and returns an instance of this provider. 50 // Creates and returns an instance of this provider.
56 static ZeroSuggestProvider* Create(AutocompleteProviderListener* listener, 51 static ZeroSuggestProvider* Create(AutocompleteProviderListener* listener,
57 Profile* profile); 52 Profile* profile);
58 53
59 // AutocompleteProvider: 54 // AutocompleteProvider:
60 virtual void Start(const AutocompleteInput& input, 55 virtual void Start(const AutocompleteInput& input,
61 bool /*minimal_changes*/) OVERRIDE; 56 bool /*minimal_changes*/) OVERRIDE;
62 virtual void Stop(bool clear_cached_results) OVERRIDE; 57 virtual void Stop(bool clear_cached_results) OVERRIDE;
63 58
(...skipping 28 matching lines...) Expand all
92 // arguments) were copied and trimmed from SearchProvider. 87 // arguments) were copied and trimmed from SearchProvider.
93 // TODO(hfung): Refactor them into a new base class common to both 88 // TODO(hfung): Refactor them into a new base class common to both
94 // ZeroSuggestProvider and SearchProvider. 89 // ZeroSuggestProvider and SearchProvider.
95 90
96 // From the OpenSearch formatted response |root_val|, populate query 91 // From the OpenSearch formatted response |root_val|, populate query
97 // suggestions into |suggest_results|, navigation suggestions into 92 // suggestions into |suggest_results|, navigation suggestions into
98 // |navigation_results|, and the verbatim relevance score into 93 // |navigation_results|, and the verbatim relevance score into
99 // |verbatim_relevance|. 94 // |verbatim_relevance|.
100 void FillResults(const base::Value& root_val, 95 void FillResults(const base::Value& root_val,
101 int* verbatim_relevance, 96 int* verbatim_relevance,
102 SearchProvider::SuggestResults* suggest_results, 97 SuggestResults* suggest_results,
103 SearchProvider::NavigationResults* navigation_results); 98 NavigationResults* navigation_results);
104 99
105 // Creates AutocompleteMatches to search |template_url| for "<suggestion>" for 100 // Creates AutocompleteMatches to search |template_url| for "<suggestion>" for
106 // all suggestions in |results|, and adds them to |map|. 101 // all suggestions in |results|, and adds them to |map|.
107 void AddSuggestResultsToMap(const SearchProvider::SuggestResults& results, 102 void AddSuggestResultsToMap(const SuggestResults& results,
108 const TemplateURL* template_url, 103 const TemplateURL* template_url,
109 SearchProvider::MatchMap* map); 104 MatchMap* map);
110 105
111 // Creates an AutocompleteMatch with the provided |relevance| and |type| to 106 // Creates an AutocompleteMatch with the provided |relevance| and |type| to
112 // search |template_url| for |query_string|. |accepted_suggestion| will be 107 // search |template_url| for |query_string|. |accepted_suggestion| will be
113 // used to generate Assisted Query Stats. 108 // used to generate Assisted Query Stats.
114 // 109 //
115 // Adds this match to |map|; if such a match already exists, whichever one 110 // Adds this match to |map|; if such a match already exists, whichever one
116 // has lower relevance is eliminated. 111 // has lower relevance is eliminated.
117 void AddMatchToMap(int relevance, 112 void AddMatchToMap(int relevance,
118 AutocompleteMatch::Type type, 113 AutocompleteMatch::Type type,
119 const TemplateURL* template_url, 114 const TemplateURL* template_url,
120 const base::string16& query_string, 115 const base::string16& query_string,
121 int accepted_suggestion, 116 int accepted_suggestion,
122 SearchProvider::MatchMap* map); 117 MatchMap* map);
123 118
124 // Returns an AutocompleteMatch for a navigational suggestion |navigation|. 119 // Returns an AutocompleteMatch for a navigational suggestion |navigation|.
125 AutocompleteMatch NavigationToMatch( 120 AutocompleteMatch NavigationToMatch(const NavigationResult& navigation);
126 const SearchProvider::NavigationResult& navigation);
127 121
128 // Fetches zero-suggest suggestions by sending a request using |suggest_url|. 122 // Fetches zero-suggest suggestions by sending a request using |suggest_url|.
129 void Run(const GURL& suggest_url); 123 void Run(const GURL& suggest_url);
130 124
131 // Parses results from the zero-suggest server and updates results. 125 // Parses results from the zero-suggest server and updates results.
132 void ParseSuggestResults(const base::Value& root_val); 126 void ParseSuggestResults(const base::Value& root_val);
133 127
134 // Converts the parsed results to a set of AutocompleteMatches and adds them 128 // Converts the parsed results to a set of AutocompleteMatches and adds them
135 // to |matches_|. Also update the histograms for how many results were 129 // to |matches_|. Also update the histograms for how many results were
136 // received. 130 // received.
(...skipping 23 matching lines...) Expand all
160 base::string16 permanent_text_; 154 base::string16 permanent_text_;
161 155
162 // Fetcher used to retrieve results. 156 // Fetcher used to retrieve results.
163 scoped_ptr<net::URLFetcher> fetcher_; 157 scoped_ptr<net::URLFetcher> fetcher_;
164 // Whether there's a pending request in flight. 158 // Whether there's a pending request in flight.
165 bool have_pending_request_; 159 bool have_pending_request_;
166 160
167 // Suggestion for the current URL. 161 // Suggestion for the current URL.
168 AutocompleteMatch current_url_match_; 162 AutocompleteMatch current_url_match_;
169 // Navigation suggestions for the most recent ZeroSuggest input URL. 163 // Navigation suggestions for the most recent ZeroSuggest input URL.
170 SearchProvider::NavigationResults navigation_results_; 164 NavigationResults navigation_results_;
171 // Query suggestions for the most recent ZeroSuggest input URL. 165 // Query suggestions for the most recent ZeroSuggest input URL.
172 SearchProvider::MatchMap query_matches_map_; 166 MatchMap query_matches_map_;
173 // The relevance score for the URL of the current page. 167 // The relevance score for the URL of the current page.
174 int verbatim_relevance_; 168 int verbatim_relevance_;
175 169
176 // Whether a field trial, if any, has triggered in the most recent 170 // Whether a field trial, if any, has triggered in the most recent
177 // autocomplete query. This field is set to true if the last request 171 // autocomplete query. This field is set to true if the last request
178 // was a zero suggest request, the provider has completed and their 172 // was a zero suggest request, the provider has completed and their
179 // corresponding response contained '"google:fieldtrialtriggered":true'. 173 // corresponding response contained '"google:fieldtrialtriggered":true'.
180 bool field_trial_triggered_; 174 bool field_trial_triggered_;
181 // Whether a zero suggest request triggered a field trial in the omnibox 175 // Whether a zero suggest request triggered a field trial in the omnibox
182 // session. The user could have clicked on a suggestion when zero suggest 176 // session. The user could have clicked on a suggestion when zero suggest
183 // triggered (same condition as field_trial_triggered_), or triggered zero 177 // triggered (same condition as field_trial_triggered_), or triggered zero
184 // suggest but kept typing. 178 // suggest but kept typing.
185 bool field_trial_triggered_in_session_; 179 bool field_trial_triggered_in_session_;
186 180
187 history::MostVisitedURLList most_visited_urls_; 181 history::MostVisitedURLList most_visited_urls_;
188 182
189 // For callbacks that may be run after destruction. 183 // For callbacks that may be run after destruction.
190 base::WeakPtrFactory<ZeroSuggestProvider> weak_ptr_factory_; 184 base::WeakPtrFactory<ZeroSuggestProvider> weak_ptr_factory_;
191 185
192 DISALLOW_COPY_AND_ASSIGN(ZeroSuggestProvider); 186 DISALLOW_COPY_AND_ASSIGN(ZeroSuggestProvider);
193 }; 187 };
194 188
195 #endif // CHROME_BROWSER_AUTOCOMPLETE_ZERO_SUGGEST_PROVIDER_H_ 189 #endif // CHROME_BROWSER_AUTOCOMPLETE_ZERO_SUGGEST_PROVIDER_H_
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/search_provider.cc ('k') | chrome/browser/autocomplete/zero_suggest_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698