Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(71)

Issue 1309983003: Add gyp and gn targets for jFormatString.jar needed by errorprone. (Closed)

Created:
4 years, 3 months ago by mikecase (-- gone --)
Modified:
4 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/findbugs.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add gyp and gn targets for jFormatString.jar needed by errorprone. BUG= R=jbudorick@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/findbugs/+/57f05238d3ac77ea0a194813d3065dd780c6e566

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Updated README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
M README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A findbugs.gyp View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mikecase (-- gone --)
4 years, 3 months ago (2015-08-25 22:29:05 UTC) #2
jbudorick
lgtm
4 years, 3 months ago (2015-08-25 22:30:13 UTC) #3
jbudorick
On 2015/08/25 at 22:30:13, jbudorick wrote: > lgtm ER wait, update the README.chromium
4 years, 3 months ago (2015-08-25 22:30:33 UTC) #4
mikecase (-- gone --)
4 years, 3 months ago (2015-08-25 22:52:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
57f05238d3ac77ea0a194813d3065dd780c6e566 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698