Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1309983002: Fix fake mouse move event on scroll (Closed)

Created:
5 years, 4 months ago by Xianzhu
Modified:
5 years, 4 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix fake mouse move event on scroll We made LayoutObject::previousPaintInvalidationRect() private but DeprecatedPaintLayerScrollArea is a friend of LayoutObject, so missed the change. This caused incorrect fake mouse move event on composited scroll. Will fix the friend access issue in https://codereview.chromium.org/1306993002/. BUG=516016 TEST=fast/events/overflow-composited-scroll-fake-mouse-move.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201028

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove explicit timeout on failure #

Patch Set 3 : Fix dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
A LayoutTests/fast/events/overflow-composited-scroll-fake-mouse-move.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
A + LayoutTests/fast/events/overflow-composited-scroll-fake-mouse-move-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/fast/events/overflow-scroll-fake-mouse-move.html View 1 2 chunks +4 lines, -15 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Xianzhu
5 years, 4 months ago (2015-08-21 21:23:22 UTC) #2
pdr.
LGTM https://codereview.chromium.org/1309983002/diff/1/LayoutTests/fast/events/overflow-composited-scroll-fake-mouse-move.html File LayoutTests/fast/events/overflow-composited-scroll-fake-mouse-move.html (right): https://codereview.chromium.org/1309983002/diff/1/LayoutTests/fast/events/overflow-composited-scroll-fake-mouse-move.html#newcode29 LayoutTests/fast/events/overflow-composited-scroll-fake-mouse-move.html:29: setTimeout(fail, 1000); Lets just let the test timeout ...
5 years, 4 months ago (2015-08-21 21:34:09 UTC) #3
Xianzhu
https://codereview.chromium.org/1309983002/diff/1/LayoutTests/fast/events/overflow-composited-scroll-fake-mouse-move.html File LayoutTests/fast/events/overflow-composited-scroll-fake-mouse-move.html (right): https://codereview.chromium.org/1309983002/diff/1/LayoutTests/fast/events/overflow-composited-scroll-fake-mouse-move.html#newcode29 LayoutTests/fast/events/overflow-composited-scroll-fake-mouse-move.html:29: setTimeout(fail, 1000); On 2015/08/21 21:34:09, pdr wrote: > Lets ...
5 years, 4 months ago (2015-08-21 21:40:52 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1302993003 Patch 100001). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-21 21:41:13 UTC) #8
pdr.
On 2015/08/21 at 21:41:13, commit-bot wrote: > This CL has an open dependency (Issue 1302993003 ...
5 years, 4 months ago (2015-08-21 21:47:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309983002/40001
5 years, 4 months ago (2015-08-21 21:56:07 UTC) #12
Xianzhu
On 2015/08/21 21:47:22, pdr wrote: > On 2015/08/21 at 21:41:13, commit-bot wrote: > > This ...
5 years, 4 months ago (2015-08-21 21:57:16 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 00:16:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201028

Powered by Google App Engine
This is Rietveld 408576698