Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 1309963003: Introduce composed tree version of isFirstPositionAfterTable() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce composed tree version of isFirstPositionAfterTable() This patch introduces composed tree version of |isFirstPositionAfterTable()| by templatizing original |isFirstPositionAfterTable()| to work both DOM tree position and composed tree position version for introducing composed tree version of |VisibleSelection| class. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201904

Patch Set 1 : 2015-09-08T15:06:09 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M Source/core/editing/EditingUtilities.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 chunk +14 lines, -3 lines 0 comments Download
M Source/core/editing/EditingUtilitiesTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-08 06:37:06 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-09-08 06:39:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309963003/1
5 years, 3 months ago (2015-09-08 06:40:42 UTC) #5
yoichio
Change itself is good. However, |isFirstPositionAfterTable| returns other than bool is too strange. Could you ...
5 years, 3 months ago (2015-09-08 06:48:59 UTC) #6
yosin_UTC9
On 2015/09/08 06:48:59, yoichio wrote: > Change itself is good. > However, |isFirstPositionAfterTable| returns other ...
5 years, 3 months ago (2015-09-08 07:10:24 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 08:58:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201904

Powered by Google App Engine
This is Rietveld 408576698