Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1309953003: Remove unused securityState code in WebInspector.SecurityModel. (Closed)

Created:
5 years, 3 months ago by lgarron
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unused securityState code in WebInspector.SecurityModel. The Chrome-side security handler now sends a SecurityStyleChanged event upon being enabled, so it is not necessary for SecurityModel to do anything to keep track of security state anymore. BUG= Committed: https://crrev.com/c9ebdc59e3e757dead4dad86efb729bf2ccd6d69 git-svn-id: svn://svn.chromium.org/blink/trunk@202016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M Source/devtools/front_end/security/SecurityModel.js View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
lgarron
pfeldman@: Could you review?
5 years, 3 months ago (2015-09-04 23:19:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309953003/1
5 years, 3 months ago (2015-09-04 23:34:15 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-05 00:50:02 UTC) #6
lgarron
ping :-)
5 years, 3 months ago (2015-09-09 22:25:52 UTC) #7
pfeldman
lgtm
5 years, 3 months ago (2015-09-09 23:54:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309953003/1
5 years, 3 months ago (2015-09-09 23:55:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202016
5 years, 3 months ago (2015-09-10 01:30:18 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:06:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9ebdc59e3e757dead4dad86efb729bf2ccd6d69

Powered by Google App Engine
This is Rietveld 408576698