Issue 1309933003: datastore: Add DecodeCursor to [Raw]Interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1309933003: datastore: Add DecodeCursor to [Raw]Interface. (Closed)

Created:
5 years, 4 months ago by dnj

Modified:
5 years, 4 months ago

Reviewers:
iannucci

CC:
chromium-reviews

Base URL:
https://github.com/luci/gae@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

datastore: Add DecodeCursor to [Raw]Interface. R=iannucci@chromium.org BUG= Committed: https://github.com/luci/gae/commit/19121d4476fa4c6dc1e4405f77a48a921bba8214

Patch Set 2 : Track error in count filter. #

Patch Set 3 : Use more concise formulation. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -3 lines)			Patch
M	filter/count/rds.go	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	impl/dummy/dummy.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	impl/memory/datastore.go	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	impl/memory/datastore_query.go	View		3 chunks	+14 lines, -1 line	0 comments	Download
M	impl/prod/raw_datastore.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	service/datastore/datastore.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	service/datastore/interface.go	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	service/datastore/raw_interface.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

iannucci

lgtm https://codereview.chromium.org/1309933003/diff/1/filter/count/rds.go File filter/count/rds.go (right): https://codereview.chromium.org/1309933003/diff/1/filter/count/rds.go#newcode51 filter/count/rds.go:51: return r.ds.DecodeCursor(s) I think you want ret, err ...

5 years, 4 months ago (2015-08-21 23:30:03 UTC) #2

dnj

5 years, 4 months ago (2015-08-21 23:57:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
19121d4476fa4c6dc1e4405f77a48a921bba8214 (presubmit successful).