Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1309903009: [arm] Decrease the size of the assembler class by allocating buffers of pending constants on the he… (Closed)

Created:
5 years, 3 months ago by Igor Sheludko
Modified:
5 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Decrease the size of the assembler class by allocating buffers of pending constants on the heap. BUG=chromium:521828 LOG=N Committed: https://crrev.com/033af3fa511c52bc4049cd278d0623a6c6f9f9c3 Cr-Commit-Position: refs/heads/master@{#30592}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 4 chunks +26 lines, -0 lines 0 comments Download
M src/ic/access-compiler.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Igor Sheludko
PTAL
5 years, 3 months ago (2015-09-04 14:54:36 UTC) #2
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/1309903009/diff/1/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/1309903009/diff/1/src/arm/assembler-arm.cc#newcode3678 src/arm/assembler-arm.cc:3678: // Inline buffer is over, switch ...
5 years, 3 months ago (2015-09-04 15:20:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309903009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309903009/20001
5 years, 3 months ago (2015-09-04 15:28:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-04 15:50:46 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/033af3fa511c52bc4049cd278d0623a6c6f9f9c3 Cr-Commit-Position: refs/heads/master@{#30592}
5 years, 3 months ago (2015-09-04 15:50:59 UTC) #8
Igor Sheludko
5 years, 3 months ago (2015-09-04 16:09:42 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1307863007/ by ishell@chromium.org.

The reason for reverting is: Static assert failed on ARM64.

Powered by Google App Engine
This is Rietveld 408576698