Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1309903006: [NetInfo] Clean up after adding connection.downlinkMax (Closed)

Created:
3 years, 9 months ago by jkarlin
Modified:
3 years, 9 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@netinfo
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[NetInfo] Clean up after adding connection.downlinkMax Patch 1) https://crrev.com/1308943005 Patch 2) https://crrev.com/1306423004 Patch 3) https://crrev.com/1309903006 (this) BUG=412741 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202589

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove implementation as well #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M Source/web/WebNetworkStateNotifier.cpp View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebNetworkStateNotifier.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jkarlin
jochen: PTAL at this clean up, thanks!
3 years, 9 months ago (2015-09-21 14:48:20 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2015-09-21 14:56:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309903006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309903006/80001
3 years, 9 months ago (2015-09-21 17:34:06 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2015-09-21 17:57:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202589

Powered by Google App Engine
This is Rietveld 408576698