Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309893002: Remove unusued WebFrameClient::willRequestResource and WebCachedURLRequest (Closed)

Created:
5 years, 4 months ago by Nate Chapin
Modified:
5 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unusued WebFrameClient::willRequestResource and WebCachedURLRequest Also, remove android's resource-request-callbacks-expected.txt, which I missed when deleting the test in https://codereview.chromium.org/1288323006/ BUG=523091 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -170 lines) Patch
D LayoutTests/platform/android/fast/loader/resource-request-callbacks-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D Source/web/WebCachedURLRequest.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D public/web/WebCachedURLRequest.h View 1 chunk +0 lines, -69 lines 0 comments Download
M public/web/WebFrameClient.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309893002/1
5 years, 4 months ago (2015-08-21 18:02:15 UTC) #2
Nate Chapin
5 years, 4 months ago (2015-08-21 18:02:55 UTC) #4
Mike West
Deleting things LGTM.
5 years, 4 months ago (2015-08-21 18:38:21 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-21 19:39:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309893002/1
5 years, 4 months ago (2015-08-21 19:46:42 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 19:51:15 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201006

Powered by Google App Engine
This is Rietveld 408576698