Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309883002: Get rid of CompilationInfo::GenerateCodeStub method. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
titzer, Yang
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Get rid of CompilationInfo::GenerateCodeStub method. R=titzer@chromium.org Committed: https://crrev.com/29110072403e03c4384d615628e767cbe58a2cb8 Cr-Commit-Position: refs/heads/master@{#30317}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -31 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -9 lines 0 comments Download
M src/compiler.h View 3 chunks +4 lines, -7 lines 1 comment Download
M src/compiler.cc View 2 chunks +18 lines, -10 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
Michael Starzinger
https://codereview.chromium.org/1309883002/diff/1/src/compiler.h File src/compiler.h (left): https://codereview.chromium.org/1309883002/diff/1/src/compiler.h#oldcode405 src/compiler.h:405: Handle<Code> GenerateCodeStub(); Pretty please, with a cherry on top, ...
5 years, 4 months ago (2015-08-21 16:24:30 UTC) #1
titzer
lgtm agree completely please more better
5 years, 4 months ago (2015-08-21 16:35:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309883002/1
5 years, 4 months ago (2015-08-21 16:37:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5127)
5 years, 4 months ago (2015-08-21 16:39:40 UTC) #6
Michael Starzinger
Yang: Needs OWNERS approval for debugger.
5 years, 4 months ago (2015-08-21 16:42:05 UTC) #8
Michael Starzinger
Yang: Also feel free to CQ if you approve. :)
5 years, 4 months ago (2015-08-21 16:44:49 UTC) #9
Yang
lgtm lgtm
5 years, 4 months ago (2015-08-24 06:29:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309883002/1
5 years, 4 months ago (2015-08-24 06:29:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-24 06:52:53 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 06:53:06 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/29110072403e03c4384d615628e767cbe58a2cb8
Cr-Commit-Position: refs/heads/master@{#30317}

Powered by Google App Engine
This is Rietveld 408576698