Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309873005: Introduce DeleteRegValueWorkItemTest.DeleteValueInNonExistentKey and modernize associated fixture a… (Closed)

Created:
5 years, 3 months ago by gab
Modified:
5 years, 3 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@a1_no_delegate_execute_win10
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce DeleteRegValueWorkItemTest.DeleteValueInNonExistentKey and modernize associated fixture and tests. BUG=516349 (as a follow-up CL to the fix) Committed: https://crrev.com/09a034117b76684f49f9bb7cf3b5eaf1411ccf6d Cr-Commit-Position: refs/heads/master@{#346325}

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -55 lines) Patch
M chrome/installer/util/delete_reg_value_work_item_unittest.cc View 1 4 chunks +74 lines, -55 lines 0 comments Download

Depends on Patchset:

Issue 1294863006 Patch 60001

Messages

Total messages: 8 (2 generated)
gab
Greg PTAL, as requested @ https://codereview.chromium.org/1294863006/diff/1/chrome/installer/util/shell_util.cc#newcode687
5 years, 3 months ago (2015-08-29 14:14:17 UTC) #2
grt (UTC plus 2)
lgtm. Watch the xp bots when this lands. :-)
5 years, 3 months ago (2015-08-29 14:45:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309873005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309873005/20001
5 years, 3 months ago (2015-08-30 01:07:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-30 01:11:27 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/09a034117b76684f49f9bb7cf3b5eaf1411ccf6d Cr-Commit-Position: refs/heads/master@{#346325}
5 years, 3 months ago (2015-08-30 01:12:11 UTC) #7
gab
5 years, 3 months ago (2015-08-31 11:12:39 UTC) #8
Message was sent while issue was closed. 
On 2015/08/29 14:45:04, grt wrote:
> lgtm. Watch the xp bots when this lands. :-)

Works on XP :-) --
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds...

Powered by Google App Engine
This is Rietveld 408576698