Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309873002: Refactor webmidi tests to get rid of flakiness (Closed)

Created:
5 years, 4 months ago by Lalit Maganti
Modified:
5 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@permissions-fix
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactor webmidi tests to get rid of flakiness These tests were likely flaky because of a race between setPermission and the subsequent request. Utilize the new helper function for setting permissions to rewrite the tests in terms of promises and remove the races. BUG=519007 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201063

Patch Set 1 #

Patch Set 2 : Fix issues on review #

Patch Set 3 : Fix webmidi #

Total comments: 1

Patch Set 4 : Fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -31 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webmidi/permission.html View 1 2 3 3 chunks +34 lines, -30 lines 0 comments Download
M LayoutTests/webmidi/permission-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1305043004 Patch 100001

Messages

Total messages: 22 (11 generated)
Lalit Maganti
PTAL
5 years, 4 months ago (2015-08-21 16:17:08 UTC) #2
mlamouri (slow - plz ping)
lgtm with indentation fix https://codereview.chromium.org/1309873002/diff/40001/LayoutTests/webmidi/permission.html File LayoutTests/webmidi/permission.html (right): https://codereview.chromium.org/1309873002/diff/40001/LayoutTests/webmidi/permission.html#newcode26 LayoutTests/webmidi/permission.html:26: shouldBeDefined("promise"); nit: indentation is broken
5 years, 4 months ago (2015-08-24 09:56:34 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1305043004 Patch 100001). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-24 10:15:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309873002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309873002/60001
5 years, 4 months ago (2015-08-24 10:22:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103013)
5 years, 4 months ago (2015-08-24 10:49:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309873002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309873002/60001
5 years, 4 months ago (2015-08-24 10:55:24 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103020)
5 years, 4 months ago (2015-08-24 11:17:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309873002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309873002/60001
5 years, 4 months ago (2015-08-24 11:17:57 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103025)
5 years, 4 months ago (2015-08-24 11:41:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309873002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309873002/60001
5 years, 4 months ago (2015-08-24 14:37:33 UTC) #21
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 15:21:01 UTC) #22
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201063

Powered by Google App Engine
This is Rietveld 408576698