Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 1309843013: extensions: Avoid using WebString in Dispatcher::Dispatcher() (Closed)

Created:
5 years, 3 months ago by bashi
Modified:
5 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

extensions: Avoid using WebString in Dispatcher::Dispatcher() We can't use Blink public APIs in the constructor of Dispatcher because Blink is not initialized when we create Dispatcher. See [1] for details. [1] https://codereview.chromium.org/1182083006/ BUG=501171 Committed: https://crrev.com/52ccbf1153a4ce91ac5600413ace937174eba02c Cr-Commit-Position: refs/heads/master@{#347809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M extensions/renderer/dispatcher.cc View 3 chunks +31 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bashi
PTAL?
5 years, 3 months ago (2015-09-08 00:47:35 UTC) #2
not at google - send to devlin
lgtm
5 years, 3 months ago (2015-09-08 16:17:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309843013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309843013/1
5 years, 3 months ago (2015-09-08 21:41:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 22:20:36 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 22:21:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52ccbf1153a4ce91ac5600413ace937174eba02c
Cr-Commit-Position: refs/heads/master@{#347809}

Powered by Google App Engine
This is Rietveld 408576698