Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 1309843011: Fix Resource leak in ActivityLoggerTest unit tests. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
haraken, Nate Chapin, Nico
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix Resource leak in ActivityLoggerTest unit tests. Evict resources from the memory cache upon shutdown. R=haraken BUG=526423 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/web/tests/ActivityLoggerTest.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 3 months ago (2015-09-02 09:42:26 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-02 09:44:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309843011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309843011/1
5 years, 3 months ago (2015-09-02 10:54:27 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 10:59:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201634

Powered by Google App Engine
This is Rietveld 408576698