Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 1309843007: [Interpreter] Add support for property load operations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index 8a45c73bbbcbb4a7bd44ca05142c8ad63da08b4d..35c2a6bb8ef940ccfe06c8a0227df7c677a57d97 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -51,6 +51,12 @@ class BytecodeArrayBuilder {
BytecodeArrayBuilder& LoadAccumulatorWithRegister(Register reg);
BytecodeArrayBuilder& StoreAccumulatorInRegister(Register reg);
+ // Load properties. The object being accessed should be in the accumulator.
+ BytecodeArrayBuilder& LoadNamedProperty(Register name, int feedback_slot,
+ LanguageMode language_mode);
+ BytecodeArrayBuilder& LoadKeyedProperty(Register key, int feedback_slot,
+ LanguageMode language_mode);
+
// Operators.
BytecodeArrayBuilder& BinaryOperation(Token::Value binop, Register reg);
@@ -62,6 +68,8 @@ class BytecodeArrayBuilder {
-InterpreterFrameConstants::kLastParamFromRegisterPointer / kPointerSize;
static Bytecode BytecodeForBinaryOperation(Token::Value op);
+ template <typename T>
+ static bool FitsByteOperand(T value);
void Output(Bytecode bytecode, uint8_t r0, uint8_t r1, uint8_t r2);
void Output(Bytecode bytecode, uint8_t r0, uint8_t r1);

Powered by Google App Engine
This is Rietveld 408576698