components/variations/variations_switches.h - Issue 1309843005: Remove more //chrome dependencies from VariationsService

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/variations/variations_switches.h

Issue 1309843005: Remove more //chrome dependencies from VariationsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@variations_service_get_channel

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/metrics/variations/variations_service.cc ('K') | « components/variations/service/variations_service_client.h ('k') | components/variations/variations_switches.cc » ('j') | components/variations/variations_switches.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_VARIATIONS_VARIATIONS_SWITCHES_H_

	6 #define COMPONENTS_VARIATIONS_VARIATIONS_SWITCHES_H_

	7

	8 namespace chrome_variations {
	Alexei Svitkine (slow) 2015/08/27 18:27:10 Eventually this should be "variations". Any reason Eventually this should be "variations". Any reason it can't start that way? blundell 2015/08/27 18:33:02 The same reason that the other code I've moved ove Show quoted text On 2015/08/27 18:27:10, Alexei Svitkine wrote: > Eventually this should be "variations". Any reason it can't start that way? The same reason that the other code I've moved over has stayed in the chrome_variations namespace: to avoid churn in VariationsService.
	9 namespace switches {

	10

	11 // Alphabetical list of switches specific to the variations component. Document

	12 // each in the .cc file.

	13

	14 extern const char kFakeVariationsChannel[];

	15 extern const char kVariationsServerURL[];

	16

	17 } // namespace switches

	18 } // namespace variations

	19

	20 #endif // COMPONENTS_VARIATIONS_VARIATIONS_SWITCHES_H_

OLD	NEW