Reduce spam from CQ.

Reduce spam from CQ.

My previous change https://codereview.chromium.org/138173005/ made CQ
post a message when the commit box was unchecked.  It shouldn't have
posted it when CQ committed a change, but for some obscure reason it
did.  Sometimes twice...

This patch unifies the way an issue is removed from the queue, and in
particular, should eliminate most of the unwanted messages.  Some CQ
messages about unchecked CQ box will still be posted when CQ drops it,
and it is expected to be rare.

BUG=339116
R=phajdan.jr@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=248553

[Sergey Berezin, 2014-02-01 01:24:57]

Unit test updates: comments for the record.

https://codereview.chromium.org/130983010/diff/160001/tests/pending_manager_t...
File tests/pending_manager_test.py (right):

https://codereview.chromium.org/130983010/diff/160001/tests/pending_manager_t...
tests/pending_manager_test.py:109: "set_flag(%d, 1, 'commit', False)" % issue,
Since committing a message calls _discard_pending(), it explicitly unchecks the
CQ box, and logs an additional 'abort' message. All the unit tests are updated
to reflect this.

https://codereview.chromium.org/130983010/diff/160001/tests/project_test.py
File tests/project_test.py (right):

https://codereview.chromium.org/130983010/diff/160001/tests/project_test.py#n...
tests/project_test.py:438: self.time = map(lambda x: float(x*35), range(16))
_discard_pending() is responsible for the extra time.time() call. I think we
should relax the strict count of time() calls, and just make it an infinite
stream, it's too fragile. In particular, it breaks these tests if run manually
with -v.

[Paweł Hajdan Jr., 2014-02-03 18:47:33]

LGTM with a comment

https://codereview.chromium.org/130983010/diff/160001/pending_manager.py
File pending_manager.py (right):

https://codereview.chromium.org/130983010/diff/160001/pending_manager.py#newc...
pending_manager.py:547: self._discard_pending(pending,
I think this discard_pending call should be outside this try-except.

Even if AE (AppEngine) is flaky, CQ should still discard the issue.

[iannucci, 2014-02-03 19:21:32]

https://codereview.chromium.org/130983010/diff/160001/pending_manager.py
File pending_manager.py (right):

https://codereview.chromium.org/130983010/diff/160001/pending_manager.py#newc...
pending_manager.py:547: self._discard_pending(pending,
On 2014/02/03 18:47:34, Paweł Hajdan Jr. wrote:
> I think this discard_pending call should be outside this try-except.
> 
> Even if AE (AppEngine) is flaky, CQ should still discard the issue.

Yes, but then the Issue won't have the final committed message. They should both
be done together in a transaction.

[Sergey Berezin, 2014-02-03 19:48:43]

Made the change as Pawel suggested.

https://codereview.chromium.org/130983010/diff/160001/pending_manager.py
File pending_manager.py (right):

https://codereview.chromium.org/130983010/diff/160001/pending_manager.py#newc...
pending_manager.py:547: self._discard_pending(pending,
Actually, moving _discard_pending() after try...except makes it a higher chance
that the message will be posted regardless of the status update, which I prefer
to a silent commit.

Personally, I'd even move _discard_pending() right after checkout.commit() call
above, but we like it to appear in a special color.

[Sergey Berezin, 2014-02-03 19:48:58]

The CQ bit was checked by sergeyberezin@chromium.org

[commit-bot: I haz the power, 2014-02-03 19:49:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyberezin@chromium.org/130983010/2...

[commit-bot: I haz the power, 2014-02-03 19:49:31]

Change committed as 248553

[commit-bot: I haz the power, 2014-02-03 19:49:38]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 19:49:38]

CQ bit was unchecked on CL. Ignoring.

[Sergey Berezin, 2014-02-04 00:04:19]

A revert of this CL has been created in
https://codereview.chromium.org/136643007/ by sergeyberezin@chromium.org.

The reason for reverting is: This did not fix the noise from the CQ. Reverting
this and the previous patches..