src/interpreter/bytecode-generator.cc - Issue 1309813007: [es6] implement destructuring assignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 1309813007: [es6] implement destructuring assignment (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove facilities for rewriting the expression multiple ways Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-generator.cc

diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc

index 86dbf1adb06459eb83b1604975f68e8804f4b384..c19523e3734873c60ffdc6bf8473ec72ad48a6f2 100644

--- a/src/interpreter/bytecode-generator.cc

+++ b/src/interpreter/bytecode-generator.cc

@@ -2036,6 +2036,11 @@ void BytecodeGenerator::VisitLogicalAndExpression(BinaryOperation* binop) {

}

+void BytecodeGenerator::VisitRewritableExpression(RewritableExpression* expr) {

+ Visit(expr->expression());

void BytecodeGenerator::VisitNewLocalFunctionContext() {

AccumulatorResultScope accumulator_execution_result(this);

Scope* scope = this->scope();