src/compiler/ast-loop-assignment-analyzer.cc - Issue 1309813007: [es6] implement destructuring assignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-loop-assignment-analyzer.cc

Issue 1309813007: [es6] implement destructuring assignment (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove facilities for rewriting the expression multiple ways Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-loop-assignment-analyzer.cc

diff --git a/src/compiler/ast-loop-assignment-analyzer.cc b/src/compiler/ast-loop-assignment-analyzer.cc

index 7878d776bea72184afaed8c2be83036b97bb2b2c..b65434ce852057a73ba03870595d607bbe7300a3 100644

--- a/src/compiler/ast-loop-assignment-analyzer.cc

+++ b/src/compiler/ast-loop-assignment-analyzer.cc

@@ -288,6 +288,11 @@ void ALAA::VisitCountOperation(CountOperation* e) {

}

+void ALAA::VisitRewritableExpression(RewritableExpression* expr) {

+ Visit(expr->expression());

void ALAA::AnalyzeAssignment(Variable* var) {

if (!loop_stack_.empty() && var->IsStackAllocated()) {

loop_stack_.back()->Add(GetVariableIndex(info()->scope(), var));