src/interpreter/bytecode-generator.cc - Issue 1309813007: [es6] implement destructuring assignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 1309813007: [es6] implement destructuring assignment (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Cache te right scope in DeclareAndInitializeVariables() Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-generator.cc

diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc

index d4755a6dde21d19ea87595b03e32f4bf4747e1dd..3c6da15a3842605154fc48eb083793d641be9fd0 100644

--- a/src/interpreter/bytecode-generator.cc

+++ b/src/interpreter/bytecode-generator.cc

@@ -1430,6 +1430,8 @@ void BytecodeGenerator::VisitVariableAssignment(Variable* variable,

void BytecodeGenerator::VisitAssignment(Assignment* expr) {

+ RETURN_IF_VISIT_NODE(expr->destructuring_assignment());

DCHECK(expr->target()->IsValidReferenceExpression());

size_t name_index = kMaxUInt32;