src/crankshaft/hydrogen.cc - Issue 1309813007: [es6] implement destructuring assignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 1309813007: [es6] implement destructuring assignment (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Cache te right scope in DeclareAndInitializeVariables() Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 1e9b0bdb9432c2ac6f20fa3d191d458caf5e3b8a..7384573daca9dabfed7603af496f767f64c8d846 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -7050,6 +7050,8 @@ void HOptimizedGraphBuilder::VisitAssignment(Assignment* expr) {

DCHECK(!HasStackOverflow());

DCHECK(current_block() != NULL);

DCHECK(current_block()->HasPredecessor());

+ RETURN_IF_VISIT_NODE(expr->destructuring_assignment());

VariableProxy* proxy = expr->target()->AsVariableProxy();

Property* prop = expr->target()->AsProperty();

DCHECK(proxy == NULL || prop == NULL);