src/compiler/ast-graph-builder.cc - Issue 1309813007: [es6] implement destructuring assignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1309813007: [es6] implement destructuring assignment (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Cache te right scope in DeclareAndInitializeVariables() Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-graph-builder.cc

diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc

index a8d6093246f721d88174b924fee1dcd9f64d13d3..7320cca3ee2441ba130e47f17ccc7c4547167726 100644

--- a/src/compiler/ast-graph-builder.cc

+++ b/src/compiler/ast-graph-builder.cc

@@ -2065,6 +2065,7 @@ void AstGraphBuilder::VisitForInAssignment(Expression* expr, Node* value,

void AstGraphBuilder::VisitAssignment(Assignment* expr) {

+ RETURN_IF_VISIT_NODE(expr->destructuring_assignment());

DCHECK(expr->target()->IsValidReferenceExpressionOrThis());

// Left-hand side can only be a property, a global or a variable slot.