net/quic/test_tools/crypto_test_utils.cc - Issue 1309813003: Implement an openssl version of a QUIC ProofSource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/test_tools/crypto_test_utils.cc

Issue 1309813003: Implement an openssl version of a QUIC ProofSource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add proof_source_chromium_openssl.cc Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/quic/crypto/proof_source_chromium_openssl.cc ('K') | « net/quic/quic_crypto_server_stream_test.cc ('k') | net/quic/test_tools/crypto_test_utils_chromium.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/test_tools/crypto_test_utils.cc

diff --git a/net/quic/test_tools/crypto_test_utils.cc b/net/quic/test_tools/crypto_test_utils.cc

index 811da803f1a59c3e60021afc2c6155436fa2a242..372923d21f4439177aba7a1029c045b2e685d496 100644

--- a/net/quic/test_tools/crypto_test_utils.cc

+++ b/net/quic/test_tools/crypto_test_utils.cc

@@ -228,9 +228,7 @@ int CryptoTestUtils::HandshakeWithFakeClient(

QuicServerId server_id(kServerHostname, kServerPort, is_https,

PRIVACY_MODE_DISABLED);

if (!options.dont_verify_certs) {

- // TODO(wtc): replace this with ProofVerifierForTesting() when we have

- // a working ProofSourceForTesting().

- crypto_config.SetProofVerifier(FakeProofVerifierForTesting());

+ crypto_config.SetProofVerifier(ProofVerifierForTesting());

}

TestQuicSpdyClientSession client_session(client_conn, DefaultQuicConfig(),

server_id, &crypto_config);