chrome/browser/banners/app_banner_settings_helper.h - Issue 1309803005: Allow direct and indirect navigation values to be varied via field trial.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_settings_helper.h

Issue 1309803005: Allow direct and indirect navigation values to be varied via field trial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Squash compile failure on windows Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/banners/app_banner_manager.cc ('k') | chrome/browser/banners/app_banner_settings_helper.cc » ('j') | chrome/browser/banners/app_banner_settings_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_settings_helper.h

diff --git a/chrome/browser/banners/app_banner_settings_helper.h b/chrome/browser/banners/app_banner_settings_helper.h

index 74db0265a30ffdc49904cc2e0141952280a323ef..d495f0c5d9bb8577bfb2cfba6d35dece9759f36f 100644

--- a/chrome/browser/banners/app_banner_settings_helper.h

+++ b/chrome/browser/banners/app_banner_settings_helper.h

@@ -132,10 +132,17 @@ class AppBannerSettingsHelper {

static base::Time BucketTimeToResolution(base::Time time,

unsigned int minutes);

+ // Queries a field trial for updates to the default engagement values assigned

+ // to direct and indirect navigations.

+ static void UpdateEngagementWeights();

// Queries a field trial for updates to the default number of minutes between

// site visits counted for the purposes of displaying a banner.

static void UpdateMinutesBetweenVisits();

+ // Updates all values from field trial.

+ static void UpdateFromFieldTrial();

private:

DISALLOW_IMPLICIT_CONSTRUCTORS(AppBannerSettingsHelper);

};