DevTools: Refactor memory counter display

Source/devtools/front_end/timeline/MemoryCountersGraph.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 21 matching lines @@
  * @constructor
  * @extends {WebInspector.CountersGraph}
  * @implements {WebInspector.TimelineModeView}
  * @param {!WebInspector.TimelineModeViewDelegate} delegate
  * @param {!WebInspector.TimelineModel} model
  */
 WebInspector.MemoryCountersGraph = function(delegate, model)
 {
     WebInspector.CountersGraph.call(this, WebInspector.UIString("MEMORY"), delegate, model);
     this._countersByName = {};
-    this._countersByName["jsHeapSizeUsed"] = this.createCounter(WebInspector.UIString("Used JS Heap"), WebInspector.UIString("JS Heap Size: %d"), "hsl(220, 90%, 43%)");
-    this._countersByName["documents"] = this.createCounter(WebInspector.UIString("Documents"), WebInspector.UIString("Documents: %d"), "hsl(0, 90%, 43%)");
-    this._countersByName["nodes"] = this.createCounter(WebInspector.UIString("Nodes"), WebInspector.UIString("Nodes: %d"), "hsl(120, 90%, 43%)");
-    this._countersByName["jsEventListeners"] = this.createCounter(WebInspector.UIString("Listeners"), WebInspector.UIString("Listeners: %d"), "hsl(38, 90%, 43%)");
+    this._countersByName["jsHeapSizeUsed"] = this.createCounter(WebInspector.UIString("JS Heap"), WebInspector.UIString("JS Heap: %s"), "hsl(220, 90%, 43%)", Number.bytesToString);
+    this._countersByName["documents"] = this.createCounter(WebInspector.UIString("Documents"), WebInspector.UIString("Documents: %s"), "hsl(0, 90%, 43%)", undefined);

[alph, 2015/08/26 16:59:09]

Once you make it optional, you can omit "undefined"

+    this._countersByName["nodes"] = this.createCounter(WebInspector.UIString("Nodes"), WebInspector.UIString("Nodes: %s"), "hsl(120, 90%, 43%)", undefined);
+    this._countersByName["jsEventListeners"] = this.createCounter(WebInspector.UIString("Listeners"), WebInspector.UIString("Listeners: %s"), "hsl(38, 90%, 43%)", undefined);
     if (Runtime.experiments.isEnabled("gpuTimeline")) {
-        this._gpuMemoryCounter = this.createCounter(WebInspector.UIString("GPU Memory"), WebInspector.UIString("GPU Memory [KB]: %d"), "hsl(300, 90%, 43%)");
+        this._gpuMemoryCounter = this.createCounter(WebInspector.UIString("GPU Memory"), WebInspector.UIString("GPU Memory [KB]: %s"), "hsl(300, 90%, 43%)", Number.bytesToString);
         this._countersByName["gpuMemoryUsedKB"] = this._gpuMemoryCounter;
     }
 }
 
 WebInspector.MemoryCountersGraph.prototype = {
     /**
      * @override
      * @param {?RegExp} textFilter
      */
     refreshRecords: function(textFilter)
@@ skipping 16 matching lines @@
 
             var gpuMemoryLimitCounterName = "gpuMemoryLimitKB";
             if (this._gpuMemoryCounter && (gpuMemoryLimitCounterName in counters))
                 this._gpuMemoryCounter.setLimit(counters[gpuMemoryLimitCounterName]);
         }
         this.scheduleRefresh();
     },
 
     __proto__: WebInspector.CountersGraph.prototype
 }