Issue 13097006: Add interface to SkXfermode to return a GrEffect and blend coeffs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13097006: Add interface to SkXfermode to return a GrEffect and blend coeffs. (Closed)

Created:
7 years, 9 months ago by bsalomon

Modified:
7 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add interface to SkXfermode to return a GrEffect and blend coeffs.

Patch Set 3 : Add SkGpuDevice.cpp #

Total comments: 4

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -7 lines)			Patch
M	include/core/SkXfermode.h	View	1	4 chunks	+19 lines, -2 lines	2 comments	Download
M	src/core/SkXfermode.cpp	View		2 chunks	+20 lines, -0 lines	2 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 nit + 1 question https://codereview.chromium.org/13097006/diff/7001/include/core/SkXfermode.h File include/core/SkXfermode.h (right): https://codereview.chromium.org/13097006/diff/7001/include/core/SkXfermode.h#newcode186 include/core/SkXfermode.h:186: /** A ...

7 years, 9 months ago (2013-03-27 18:12:09 UTC) #2

bsalomon

7 years, 9 months ago (2013-03-27 18:39:42 UTC) #3

Message was sent while issue was closed.

Closed with r8412.

https://codereview.chromium.org/13097006/diff/7001/include/core/SkXfermode.h
File include/core/SkXfermode.h (right):

https://codereview.chromium.org/13097006/diff/7001/include/core/SkXfermode.h#...
include/core/SkXfermode.h:186: /** A subclass may implement this factory
function to work with the GPU backend. It is legal
On 2013/03/27 18:12:09, robertphillips wrote:
> will -> with

Done.

https://codereview.chromium.org/13097006/diff/7001/src/core/SkXfermode.cpp
File src/core/SkXfermode.cpp (right):

https://codereview.chromium.org/13097006/diff/7001/src/core/SkXfermode.cpp#ne...
src/core/SkXfermode.cpp:692: if (NULL == xfermode) {
On 2013/03/27 18:12:09, robertphillips wrote:
> do we need to set 'effect' to be NULL as part of the contract?

Yes, will add that.

Expand Messages | Collapse Messages

Issue 13097006: Add interface to SkXfermode to return a GrEffect and blend coeffs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add SkGpuDevice.cpp #

Messages