Issue 1309673004: Have resetInternalsObject() handle detached documents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1309673004: Have resetInternalsObject() handle detached documents. (Closed)

Created:
5 years, 3 months ago by sof

Modified:
5 years, 3 months ago

Reviewers:
haraken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Have resetInternalsObject() handle detached documents. R=haraken BUG=524261 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201306

Patch Set 1 #

Patch Set 2 : syntax #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	Source/core/testing/v8/WebCoreTestSupport.cpp	View	1	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

please take a look. I'm able to reproduce the crash in a debugger, but reducing ...

5 years, 3 months ago (2015-08-27 10:02:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309673004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309673004/20001

5 years, 3 months ago (2015-08-27 10:48:28 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-08-27 11:03:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201306

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages