Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1309663005: Revert of Fix javac command never caching input .md5s (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@md5-extra
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix javac command never caching input .md5s (patchset #8 id:140001 of https://codereview.chromium.org/1308083002/ ) Reason for revert: Causing try-bot failures: e.g.: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/111130/steps/compile%20%28without%20patch%29/logs/stdio Original issue's description: > Fix javac command never caching input .md5s > > This was broken over a year ago by http://crrev.com/a78eb479 > > This change also removes --classes-dir (which is currently unused), and makes --jar-path (always used) required. > > It also forces the command to run if the output is missing (rather than relying completely on the .stamp file) > > On my ubiquity machine: > Add a log statement to a file in base_java then build chrome_apk: > > Before: > real 2m25.188s > user 4m52.950s > sys 1m10.064s > > After: > real 1m16.989s > user 1m13.795s > sys 0m44.040s > > BUG=523420, 379190 > > Committed: https://crrev.com/1c366880cb68fbf25050f1c6d78684eb6ae2e644 > Cr-Commit-Position: refs/heads/master@{#346975} TBR=jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=523420, 379190 Committed: https://crrev.com/a936d4429436bd69009eecdc8a8fa97763dcbe22 Cr-Commit-Position: refs/heads/master@{#347011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -122 lines) Patch
M build/android/gyp/jar.py View 2 chunks +4 lines, -2 lines 0 comments Download
M build/android/gyp/javac.py View 6 chunks +131 lines, -114 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 1 chunk +7 lines, -6 lines 0 comments Download
M build/android/rezip.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
agrieve
Created Revert of Fix javac command never caching input .md5s
5 years, 3 months ago (2015-09-02 20:30:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309663005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309663005/1
5 years, 3 months ago (2015-09-02 20:31:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 20:33:06 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a936d4429436bd69009eecdc8a8fa97763dcbe22 Cr-Commit-Position: refs/heads/master@{#347011}
5 years, 3 months ago (2015-09-02 20:33:40 UTC) #4
agrieve
5 years, 3 months ago (2015-09-02 20:41:31 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1324203002/ by agrieve@chromium.org.

The reason for reverting is: Fixed the issue..

Powered by Google App Engine
This is Rietveld 408576698