Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309653003: Speculative valgrind fix (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Speculative valgrind fix I wasn't able to repro locally but it seems like it has to be this. Committed: https://skia.googlesource.com/skia/+/6ec8b7cee7a8016ee8871faab58424ea7786c879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkLightingShader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
robertphillips
5 years, 4 months ago (2015-08-25 14:43:20 UTC) #2
robertphillips
5 years, 4 months ago (2015-08-25 16:35:46 UTC) #4
jvanverth1
lgtm
5 years, 4 months ago (2015-08-25 16:42:34 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309653003/1
5 years, 4 months ago (2015-08-25 16:43:16 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-25 16:48:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309653003/1
5 years, 4 months ago (2015-08-25 16:52:37 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 16:53:14 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6ec8b7cee7a8016ee8871faab58424ea7786c879

Powered by Google App Engine
This is Rietveld 408576698