Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309653002: bindings: Fixes build breakage of per-method [Exposed]. (Closed)

Created:
5 years, 4 months ago by Yuki
Modified:
5 years, 4 months ago
Reviewers:
haraken, dgrogan, bashi
CC:
blink-reviews, vivekg, blink-reviews-bindings_chromium.org, vivekg_samsung
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Fixes build breakage of per-method [Exposed]. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200996

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 1 comment Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Yuki
Could you review this CL?
5 years, 4 months ago (2015-08-21 06:53:50 UTC) #2
bashi
LGTM. Thanks for fixing this! https://codereview.chromium.org/1309653002/diff/1/Source/bindings/templates/methods.cpp File Source/bindings/templates/methods.cpp (left): https://codereview.chromium.org/1309653002/diff/1/Source/bindings/templates/methods.cpp#oldcode694 Source/bindings/templates/methods.cpp:694: v8::Local<v8::Function> function = ->GetFunction(isolate->GetCurrentContext())).ToLocalChecked(); ...
5 years, 4 months ago (2015-08-21 06:55:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309653002/1
5 years, 4 months ago (2015-08-21 06:56:43 UTC) #5
haraken
LGTM
5 years, 4 months ago (2015-08-21 07:05:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/42834)
5 years, 4 months ago (2015-08-21 07:31:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309653002/1
5 years, 4 months ago (2015-08-21 13:32:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/101844)
5 years, 4 months ago (2015-08-21 15:43:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309653002/1
5 years, 4 months ago (2015-08-21 15:46:29 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 17:41:15 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200996

Powered by Google App Engine
This is Rietveld 408576698