Issue 130963007: android envsetup: Stop setting TARGET_PRODUCT, don't unset ANDROID_BUILD_TOP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130963007: android envsetup: Stop setting TARGET_PRODUCT, don't unset ANDROID_BUILD_TOP. (Closed)

Created:
6 years, 11 months ago by Nico

Modified:
6 years, 10 months ago

Reviewers:
Torne

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, newt (away)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android envsetup: Stop setting TARGET_PRODUCT, don't unset ANDROID_BUILD_TOP. TARGET_PRODUCT seems to not be used in an SDK build. ANDROID_BUILD_TOP isn't used in the SDK build either. BUG=330631 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247471

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	build/android/envsetup_functions.sh	View		1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/130963007/1

6 years, 10 months ago (2014-01-28 18:17:32 UTC) #3

Message was sent while issue was closed.

Change committed as 247471

Expand Messages | Collapse Messages