chrome/browser/chrome_content_browser_client.cc - Issue 130963006: Reimplement inline signin with iframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 130963006: Reimplement inline signin with iframe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: enhance background.js to support multi-instances Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 5a671a2dd2850bd02c6b541b1597244e0135cec6..c2fe9140a072b9607a11ca8a6967b420b477308e 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -799,6 +799,10 @@ void ChromeContentBrowserClient::GetStoragePartitionConfigForSite(

*in_memory = false;

partition_name->clear();

}

+ } else if (site.GetOrigin().spec() == kChromeUIChromeSigninURL) {

+ // Chrome signin page has an embedded iframe of extension and web content,

+ // thus it must be isolated from other webUI pages.

+ *partition_domain = chrome::kChromeUIChromeSigninHost;

}

// Assert that if |can_be_default| is false, the code above must have found a