Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

Issue 130963006: Reimplement inline signin with iframe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
index 39fba15c79cd0394255ee0466881a7ac1be31929..1d491f349fe33764a4a3da6ba4574c2e9ae2cdbc 100644
--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
@@ -37,6 +37,7 @@
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/mime_types_handler.h"
#include "chrome/common/render_messages.h"
+#include "chrome/common/url_constants.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/render_process_host.h"
@@ -583,6 +584,15 @@ void ChromeResourceDispatcherHostDelegate::OnResponseStarted(
}
}
+ // Ignores x-frame-options for the chrome signin UI.
+ if (request->first_party_for_cookies().SchemeIs(chrome::kChromeUIScheme) &&
jam 2014/01/26 02:51:46 nit: also here, request->first_party_for_cookies()
guohui 2014/01/29 12:50:51 Done.
+ request->first_party_for_cookies().host() ==
+ chrome::kChromeUIChromeSigninHost) {
+ net::HttpResponseHeaders* response_headers = request->response_headers();
+ if (response_headers->HasHeader("x-frame-options"))
+ response_headers->RemoveHeader("x-frame-options");
+ }
+
prerender::URLRequestResponseStarted(request);
}

Powered by Google App Engine
This is Rietveld 408576698