Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2835)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 130963006: Reimplement inline signin with iframe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 94a6ae75e03b223261f7579db38a67bdb76274d2..22e1ec07df2afe07d7cbce4fee2affb6fb35d9cd 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -799,6 +799,11 @@ void ChromeContentBrowserClient::GetStoragePartitionConfigForSite(
*in_memory = false;
partition_name->clear();
}
+ } else if (site.SchemeIs(chrome::kChromeUIScheme) &&
+ site.host() == chrome::kChromeUIChromeSigninHost) {
jam 2014/01/26 02:51:46 nit: site.GetOrigin().spec() == kChromeUIChromeSig
guohui 2014/01/29 12:50:51 Done.
+ // Chrome signin page has an embedded iframe of extension and web content,
+ // thus it must be isolated from other webUI pages.
+ *partition_domain = chrome::kChromeUIChromeSigninHost;
}
// Assert that if |can_be_default| is false, the code above must have found a

Powered by Google App Engine
This is Rietveld 408576698